Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination to transaction lists #29

Open
im-adithya opened this issue Jun 28, 2024 · 2 comments · May be fixed by #895
Open

Add pagination to transaction lists #29

im-adithya opened this issue Jun 28, 2024 · 2 comments · May be fixed by #895
Assignees
@im-adithya
Milestone
v1.15.0

Comments

@im-adithya
Copy link
Member

Can be done by storing payments in a DB

Also, LND doesn't have a way to get total number of transactions. It also has separate methods for incoming and outgoing payments which makes it tricky while setting offset
@im-adithya im-adithya transferred this issue from getAlby/nostr-wallet-connect-next Jul 5, 2024
@im-adithya
Copy link
Member Author

We now store transactions in a table so this should be possible without LNClient limitations

@rolznz rolznz added this to the v1.12.0 milestone Nov 25, 2024
@rolznz
Copy link
Contributor

rolznz commented Nov 25, 2024

@stackingsaunter said it would be better to use shadcn pagination rather than infinite scroll for Alby Hub. In this case, we need to know the total number of transactions, which would need to be part of the response body (I think SWR cannot read headers unless we add extra logic to our fetcher in swr.ts).

@im-adithya im-adithya self-assigned this Dec 16, 2024
@im-adithya im-adithya linked a pull request Dec 16, 2024 that will close this issue
Draft
@rolznz rolznz modified the milestones: v1.12.0, v1.13.0 Dec 17, 2024
@rolznz rolznz modified the milestones: v1.13.0, v.1.14.0 Jan 7, 2025
@rolznz rolznz modified the milestones: v.1.14.0, v1.15.0 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@im-adithya im-adithya

Labels
None yet
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging a pull request may close this issue.

feat: add pagination to tx list getAlby/hub
2 participants
@rolznz @im-adithya