Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direction issue #12

Open
shabane opened this issue Dec 24, 2021 · 5 comments
Open

direction issue #12

shabane opened this issue Dec 24, 2021 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@shabane
Copy link

shabane commented Dec 24, 2021

hello again.
this theme is the best theme ever.
but it have some issue for right to left language's like Persion(Farsi).
in the other hugo them like cupper we used to add a <div dir'rtl'> at the top of each paragraph and a </div> at the end to show text in the right instead of left. but in this theme this trick doesn't work.

code

Screenshot from 2021-12-24 14-26-40

preview

rtl-issue

@tfsomrat tfsomrat added enhancement New feature or request help wanted Extra attention is needed labels Dec 26, 2021
@shabane
Copy link
Author

shabane commented Dec 26, 2021

@Gnkalk had a persion theme, my he can help us

@Gnkalk
Copy link

Gnkalk commented Dec 28, 2021

You can use https://github.com/FOSSFA/bookworm-FE
I tried to translate this template as well as I could, but a lot of work doesn't allow me to complete the translation process, you can take a fork of it and complete it.

@shabane @tfsomrat

@davidsneighbour
Copy link

In my opinion, the theme needs to be adapted to Bootstrap 5, which has RTL support integrated. Some work needs to be done exchanging left and right padding/margin/floating etc to start and end. After that is should be as easy as flipping a switch to change a layout from rtl to ltr and back.

@shabane
Copy link
Author

shabane commented Dec 28, 2021

You can use https://github.com/FOSSFA/bookworm-FE

yes i know your beautiful theme, but i liked this more than the others.
i just mention you because i thought may you have some idea to help us for this issue

@Gnkalk
Copy link

Gnkalk commented Dec 29, 2021

You can use https://github.com/FOSSFA/bookworm-FE

yes i know your beautiful theme, but i liked this more than the others. i just mention you because i thought may you have some idea to help us for this issue

I have two recommendations :

  1. Menus , Navbar and others be reversed
  2. theme search engine for Persian and Arabic and other RTL languages is not well optimized and does not provide the correct result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants