Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro-sagemaker plugin fails to execute if a kedro project has more than 100 parameters #14

Open
njvijay-mck opened this issue Jun 6, 2023 · 6 comments

Comments

@njvijay-mck
Copy link

I'm currently using the Kedro-SageMaker plugin to run a Kedro pipeline on SageMaker. My Kedro project has multiple parameters (using several parameters YAML files).

While executing kedro sagemaker run -i <image name>, I encountered this error:

ClientError: ValidationError for UpdatePipeline operation: Unable to parse pipeline definition. Model validation failed - container ProcessingEnvironmentMap length (132) exceeds maximum limit (100).

Here are the steps to reproduce the issue.

  • Add a dummy_parameter.yml file under conf/base/parameters/ in the kedro space flight example code. (check dummy_pamaramter.yml file content below)
  • Simply run kedro sagemaker run --auto-build

dummy_parameter.yml file content:

dummy_params:
  parameter1: 1
  parameter2: 2
  parameter3: 3
  parameter4: 4
  parameter5: 5
  .
  .
  .
  .
  .
 parameter100: 100
@marrrcin
Copy link
Contributor

marrrcin commented Jun 7, 2023

Thanks for creating the issue @njvijay-mck !

Do you use the feature of parameter overriding on the SageMaker UI side? If not, then maybe we can introduce a flag to skip the translation of Kedro params to SageMaker params and just rely on the config files stored in the docker image 🤔

@njvijay-mck
Copy link
Author

njvijay-mck commented Jun 7, 2023

I am not using sagemaker UI for parameter override since I rely entirely on kedro parameters yaml file (mainly for training). It is a good idea to introduce a flag to skip. But in some cases, I depend on Kedro command parameters like --env, --pipeline

@marrrcin
Copy link
Contributor

marrrcin commented Jun 12, 2023

Are you willing to contribute that feature in a form of a PR?

@njvijay-mck
Copy link
Author

I'd be happy to contribute, but it may take some time due to my current workload. I'll do my best to prioritize it as it is an important feature.

@marrrcin
Copy link
Contributor

Awesome, let's stay in touch!

@marrrcin
Copy link
Contributor

marrrcin commented Sep 5, 2023

@njvijay-mck are you still willing to contribute a fix for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants