Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Numeric slider range parameters start, end, step should be numeric, not string #20

Closed
Tracked by #19
florianm opened this issue Dec 9, 2021 · 2 comments · Fixed by #31
Closed
Tracked by #19

Numeric slider range parameters start, end, step should be numeric, not string #20

florianm opened this issue Dec 9, 2021 · 2 comments · Fixed by #31
Labels

Comments

@florianm
Copy link
Contributor

florianm commented Dec 9, 2021

A numeric field with a slider will let a user type in the numeric min, max, and step width:
image
Note the values are numeric.

In the exported XForm, this becomes a <range ref="/data/group1/slider" start="0" end="8" step="1">. Note the values are quoted strings. The XForm however uploads and works fine.

In the exported XLSForm, this becomes a parameter with value start="0" end="8" step="1". Note the values are quoted strings - this is in contrast to the XLSForm spec showing numeric values for start, end, step. build2xlsform probably did nothing wrong(er) here. The XLSForm raises an error in ODK Central:
image

Manually changing the XLSForm parameter to start=0 end=8 step=1 fixes the ODK Central error.

How much of an issue is this for Build users? Question for user analytics: How many users go from Build to XLSForm (are we logging this?) and trip over sliders (are we logging form import warnings)?

@florianm florianm self-assigned this Dec 9, 2021
@florianm
Copy link
Contributor Author

florianm commented Dec 14, 2021

This is an issue for build2xlsform. Numeric values must be quoted in XML IIRC, so Build does it right.
Edit: included in #19

@florianm florianm transferred this issue from getodk/build Dec 14, 2021
@florianm florianm mentioned this issue Dec 31, 2021
5 tasks
@florianm
Copy link
Contributor Author

florianm commented Feb 2, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant