Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save user preferences #689

Closed
matthew-white opened this issue Feb 8, 2023 · 7 comments
Closed

Save user preferences #689

matthew-white opened this issue Feb 8, 2023 · 7 comments
Assignees
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified enhancement New feature or behavior frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

matthew-white commented Feb 8, 2023

The user can make a number of selections/choices in Frontend that we've talked about persisting. We've talked about persisting them server-side. Some preferences seem to be top-level/sitewide, while others seem per-project. We already have sitewide settings (for usage reporting), project settings, and form settings. However, those are not specific to the user. This issue is about saving individual users' preferences.

Top-level/sitewide preferences to persist:

  • Whether the top panel on the homepage is shown or not (moved to #719)
  • The sort order of the project list

Project preferences:

@matthew-white
Copy link
Member Author

I've updated the description of the issue to make it clear that @brontolosone's work will close this issue. This issue is about adding a framework for saving user preferences, then using that framework for a couple of specific preferences. There are other user preferences that we want to save, and I've moved those to a separate issue (#719).

@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Sep 23, 2024
@matthew-white matthew-white added the needs testing Needs manual testing label Sep 23, 2024
@matthew-white
Copy link
Member Author

I wanted to summarize the current status of this issue:

  • The Backend for this issue has been merged.
  • We're getting close to merging the Frontend PR: Add user preference persistence framework central-frontend#1024
  • That Frontend PR patches tests so that they continue to pass, but it doesn't add new tests. Adding new tests will be done in a follow-up PR.
  • I've also filed a few follow-up issues. However, those can be tracked separately and don't need to be resolved for us to close out this issue. Once the Frontend PR is merged, and tests are in, we can close this issue.

@matthew-white
Copy link
Member Author

matthew-white commented Nov 5, 2024

Once the Frontend PR is merged, and tests are in, we can close this issue.

The Frontend PR is now merged. I've filed a separate issue about writing tests, so we can track that to-do there: getodk/central-frontend#1049. I think we can go ahead and close this issue.

@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Nov 5, 2024
@matthew-white
Copy link
Member Author

@getodk/testers, this issue is now ready to be verified. It is available on the staging server. The main way that this issue is different from #690 is that there is one other user preference to verify:

The sort order of the project list

Each user's choice/preference for the sort order of the project list should be saved. By default, projects are sorted by recent activity. If I sort projects alphabetically, then I refresh the page or open the page in a new tab, I should continue to see that projects are sorted alphabetically. My selection for the sort order of the project list should not affect what other users see: this preference is limited to my user.

@srujner
Copy link

srujner commented Nov 6, 2024

@matthew-white To make sure: The sort order of the form list should not be affected by this?

@matthew-white
Copy link
Member Author

That's right, at least for now. We've thought about adding another user preference for the sort order of the form list, and that idea is tracked at #719. The main reason we haven't added it is that we've also thought about making it possible to custom-order forms in the form list.

@srujner
Copy link

srujner commented Nov 7, 2024

Tested with Success!

@srujner srujner added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified enhancement New feature or behavior frontend Requires a change to the UI
Projects
Status: ✅ done
Development

No branches or pull requests

3 participants