Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx tests: use base nginx.dockerfile #735

Closed
alxndrsn opened this issue Oct 3, 2024 · 1 comment · Fixed by #741
Closed

nginx tests: use base nginx.dockerfile #735

alxndrsn opened this issue Oct 3, 2024 · 1 comment · Fixed by #741
Assignees
@alxndrsn
Labels
ops Docker, nginx, ops to deploy Central testing Automated integration tests, unit tests

Comments

@alxndrsn
Copy link
Contributor

alxndrsn commented Oct 3, 2024

Ref: https://github.com/getodk/central/pull/715/files#r1768897013

See:

diff test/nginx-test.dockerfile nginx.dockerfile
@alxndrsn alxndrsn self-assigned this Oct 3, 2024
@matthew-white matthew-white mentioned this issue Oct 4, 2024
Closed
@matthew-white matthew-white added ops Docker, nginx, ops to deploy Central testing Automated integration tests, unit tests labels Oct 4, 2024
@alxndrsn alxndrsn mentioned this issue Oct 6, 2024
Merged
@matthew-white
Copy link
Member

Closing now that #741 is merged into the next branch.

@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Oct 7, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✅ done in ODK Central Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxndrsn alxndrsn

Labels
ops Docker, nginx, ops to deploy Central testing Automated integration tests, unit tests
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nginx-tests: eliminate duplicate dockerfile alxndrsn/odk-central
2 participants
@alxndrsn @matthew-white