chore: migrate project to single location permission

[naman653]

Software and hardware versions

All

Problem description

Currently, we are using both Fine and Coarse location permissions for transferring forms, but only one of them is required according to our needs.

Steps to reproduce the problem

NA

Expected behavior

NA

Other information

NA

[naman653]

@lakshyagupta21 I think that for the android version higher than Android M, location is needed for sharing files. If yes, can you explain why are we requesting the enable location dialog to android version higher than Android O. Correct me if I'm wrong?

https://github.com/opendatakit/skunkworks-crow/blob/1cbb0edae9f72077112eb43eb4832ce90723fd60/skunkworks_crow/src/main/java/org/odk/share/views/ui/hotspot/HpSenderActivity.java#L204-L210

[lakshyagupta21]

@lakshyagupta21 I think that for the android version higher than Android M, location is needed for sharing files. If yes, can you explain why are we requesting the enable location dialog to an android version higher than Android O. Correct me if I'm wrong?

Thanks for pointing this out and I think it should also be present in the code comments, for some Android API's location permission is required, and for devices with Android version 7.0 or 7.1 we're navigating user to a settings page to enable the hotspot manually, because you can't trigger hotspot from the third-party apps in those android versions, so there is no point in asking user for permission but devices with Android version > 7.1, we're enabling the hotspot from the app itself in that case we require location permission. Let me know if it didn't clear your doubts.