-
Notifications
You must be signed in to change notification settings - Fork 73
feat: long press on filled forms navigate to ODK collect #344
base: master
Are you sure you want to change the base?
Conversation
Thanks for this new feature! @Chromicle . But everytime we introduce new features, you'd better send a post to ODK Forum and seek for feedback. And for this feature, how can our user know long pressing can launch the Collect? If you are the product manager, how can you design and indicate your users about this? |
As this is the small feature I feel that no need to post in the forum, I will do from the next time
There are so many sharing platforms like ShareIt and MiDrop do the same so, I feel that user can know about this feature and we can include about this feature in |
@Chromicle I would suggest to not directly start working on any new feature until it is been discussed within the community. And I agree that every feature need not be discussed on forum until and unless it is impacting large set of users.
I agree there are so many apps in market doing lot of things, but we should not do the same thing they're doing until it is really required. For taking inspiration it is completely fine but having each and every feature is not required I guess. And I agree with @huangyz0918 that features should be discussed first then we should go for the implementation. And I don't think including everything in |
Yeah, @lakshyagupta21 @huangyz0918 from now I will discuss any new feature before I work on implementation I have made a thread on slack please give your opinions |
Can we add a long press action on any item when list with checkbox is there. @Chromicle What do you think? Or if you read any article or some Google Material Design guidelines or anywhere else who recommended to implement a long press on list with checkbox, can you share it? |
Star is used for individual items and its not grouping them into one so that it can do some operation on the selected star items, if we talk about the checkboxes then we ask user to select them and then we apply some operation on them as a group which results into something useful depending on the user-chosen option. If you're seeing it now, that when you long-press the item it starts creating a list for the checked and unchecked items so that users can at last select either to delete them or mark them as unread/read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts @Chromicle , thanks.
I understood I feel that long press will be the good one to open form for checkbox, this is one more reference, this app is shareIt(one file sharing platform) |
Closes #343
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
I removed the existing method to launch collect and wrote new class
LaunchCollect
in that I gave the methodopenFormInCollect
to launch collect as we are using the same method in both the classes and I used the dependency injection for the sameGIF
How does this change affect users?
If user wants to check the form before he starts transforming he has to go the collect and check the form by, adding this feature user can directly check/review the form by long pressing the particular form
Before submitting this PR, please make sure you have:
./gradlew checkCode
and confirmed all checks still pass OR confirm CircleCI build passes