Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Add back button to settings activity #367

Open
htg2704 opened this issue Mar 3, 2020 · 14 comments
Open

Add back button to settings activity #367

htg2704 opened this issue Mar 3, 2020 · 14 comments

Comments

@htg2704
Copy link

htg2704 commented Mar 3, 2020

Software and hardware versions

Android v9, device used - Realme X2 pro

Problem description

There is no button to go back to home screen from settings screen.

Steps to reproduce the problem

It is not a problem but an unavailabilty of feature. TO reproduce, open the app, click on 3 verical dots in top right corner, go to settings. You will find there is no button for backward navigation.

Expected behavior

After solving the issue, a button will be added to settings activity.

Other information

I would like to resolve this issue.
@opendatakit-bot claim

@ajay-prabhakar
Copy link
Contributor

Hello, @htg2704 welcome to ODK, thanks for raising the issue
if you want to work on this you can claim this by @opendatakit-bot claim it will assign to you

@htg2704
Copy link
Author

htg2704 commented Mar 3, 2020

Hello, @htg2704 welcome to ODK, thanks for raising the issue
if you want to work on this you can claim this by @opendatakit-bot claim it will assign to you

How to exactly do that? I mean how to use the bot claim?

@ajay-prabhakar
Copy link
Contributor

just type @opendatakit-bot claim in the comment section
have a look here

@htg2704
Copy link
Author

htg2704 commented Mar 3, 2020

Oh ok thanks.

@htg2704
Copy link
Author

htg2704 commented Mar 6, 2020

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Hello @htg2704!

You have attempted to claim an issue without the labels "help wanted", "good first issue". It seems like you are new to Open Data Kit, so we suggest working on a good first issue issue first. After doing one quick win, then try a help wanted issue. We also recommend reading README.md and CONTRIBUTING.md before getting started.

To claim this issue anyway, comment on this issue again with the command @opendatakit-bot claim --force.

@htg2704
Copy link
Author

htg2704 commented Mar 9, 2020

@Chromicle , I have a few doubts regarding this issue. As the settings activity extends Preference activity, one cannot access the toolbar. Shall I make some bigger changes in order to implement my suggestion?

@ajay-prabhakar
Copy link
Contributor

I just gave a try, Our settings activity has to extend PreferenceActivity without that we can not use addPreferencesFromResource(R.xml.preferences_menu)
you can add the back button with setNavigationIcon to toolbar please try once again and let me know if you got stuck somewhere

@htg2704
Copy link
Author

htg2704 commented Mar 10, 2020

@opendatakit-bot claim --force

@getodk-bot
Copy link
Member

getodk-bot commented Mar 20, 2020

Hello @htg2704, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@htg2704
Copy link
Author

htg2704 commented Mar 22, 2020

@opendatakit-bot I am still working on this issue.

@alokbatham
Copy link

@getodk-bot claim

@htg2704
Copy link
Author

htg2704 commented May 2, 2020

@manit-alokbatham the pr is already up for this issue. Sorry for your inconvinience.

@getodk-bot
Copy link
Member

getodk-bot commented May 12, 2020

Hello @manit-alokbatham, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @getodk-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants