Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure fallback to global fetch has correct this binding #283

Open
eyelidlessness opened this issue Jan 20, 2025 · 0 comments
Open

Ensure fallback to global fetch has correct this binding #283

eyelidlessness opened this issue Jan 20, 2025 · 0 comments

Comments

@eyelidlessness
Copy link
Member

See #281. As I mentioned in review there:

  • I expect this also affects fetchFormAttachment. This is less urgent, because that fallback isn't particularly useful unless/until we add offline support (where a fetch call handled by a Service Worker may very well be how we handle form attachments).
  • We should add tests covering these cases, and anywhere we indirectly reference the global fetch. (Bonus points if we can find a way to automate preventing the same mistake again, as it's a pretty easy one to make.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant