-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example Idea: Capsule + Pimlico #13
Comments
Hi! Can i be assigned to this issue? |
Awesome, just assigned you! |
Hey @MrRaccxxn - any update on this? |
Got issues with my laptop, but finally okay again! Will push the PR this weekend |
Woohoo! Sounds good :) |
One question related to the issue: Should we implement a complete new project like "with-next-pimlico", or implement this as one extra step in the current version of the "with-next" folder inside the examples-hub. From my understand is the first one, but I saw another PR raised using the second approach |
Hi @MrRaccxxn! Please feel free to implement it separately so that it is a standalone app cc: @jlm0 for any additional context |
Hello! @jlm0 going through the docs of permissionless and capsule I encounter one issue at the moment of linking the "smartAccountOwner" to the owner field of toSimpleSmartAccount (The types are different. toSimpleSmartAccount expects a LocalAccount type, and it belongs to another function, createCapsuleAccount from Capsule, that is not included in the documentation). Trying to use the smartAccountOwner, I get this error because of types: Using the capsuleAccount variable bypasses this type mismatch but fails in the operation, resulting in: Note: If I skip Capsule and try the same code with privateKeyToAccount from Viem, it works as expected. |
Thank you for surfacing @MrRaccxxn! We are taking a look now |
Hi @MrRaccxxn! Appreciate your patience here, we're a bit backlogged so may take a few days to get back to you. Appreciate all the patience This will not impact your ability to get the bounty – we'll be in touch |
@MrRaccxxn I've migrated this issue to be part of our awesome-capsule repo to better showcase community contributions. Your app no longer has to be relative to the examples-hub app but rather a direct standalone application. This will help minimize any issues with dependencies or frameworks so your app submission just focusses on capsule with pimlico.
Thank you for bringing it up. Usage is createCapsuleAccount is correct and the docs are out of date and need to be updated to reflect this. Having devs like you go through integration helps us identify any missing details. So thank you!
This is likely due to how smart account operation signatures are validated. The last byte
You can see an example of this with Alchemy's AA here. Please let me know if you have any additional questions about migrating to this repo or issues with Pimlico. Thanks! |
hey @MrRaccxxn confirming you're still working on this? excited to check out your work :) |
Hello! Just putting hands on it again! will raise the PR tomorrow |
Hi @MrRaccxxn checking in on your submission status. Is there anything we can help you with? |
Sorry for not been answering on time, I will understand if this bounty is closed or moved to other, but even in that case I would like to understand what am I missing in this example. First thing first, I moved the repo from Capsule to Para to be more updated and in the migration realized some stuff that maybe could be useful:
I understand completely that migration of stuff is really hard haha, and maintain docs is always a hard work, but just to note and try to be helpful (also any of those issues apart from the styles was a blocker or took more that 1 minute to realize the correct way) Going back to my issue: I replaced the signMessage to the custom signMessage, but to sponsor the transaction we should also modify the transaction? Let’s say modify the “signTransaction”? (I tried to do a function on this, but not sure how a hashTransaction should work, and if view or any other library already has one implemented The repo is here: https://github.com/MrRaccxxn/para-pimlico And the issue kinda the same (AA23)
|
Description: Build a simple example app that uses Pimlico for account abstraction and Capsule. Leverage the Pimlico example guide to do this.
Use Case: For example, allow users to login with their social accounts via Capsule and enable gas sponsorships or bundled transactions through Pimlico.
The text was updated successfully, but these errors were encountered: