From 6c48d3c230b07a8cd5dd93e9ba61b0f395b93810 Mon Sep 17 00:00:00 2001 From: Youngjun Date: Tue, 13 Feb 2024 17:48:26 +0900 Subject: [PATCH] fixed typo in comments Signed-off-by: Youngjun --- pkg/porter/build.go | 2 +- pkg/porter/lifecycle.go | 2 +- pkg/porter/list.go | 2 +- pkg/porter/publish.go | 2 +- pkg/porter/reconcile.go | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/porter/build.go b/pkg/porter/build.go index 37b1b8af6..47e3b97da 100644 --- a/pkg/porter/build.go +++ b/pkg/porter/build.go @@ -62,7 +62,7 @@ func (o *BuildOptions) Validate(p *Porter) error { return fmt.Errorf("invalid --driver value %s", o.Driver) } - // Syncing value back to the config and we will always use the config + // Syncing value back to the config, and we will always use the config // to determine the driver // This would be less awkward if we didn't do an automatic build during publish p.Data.BuildDriver = o.Driver diff --git a/pkg/porter/lifecycle.go b/pkg/porter/lifecycle.go index 0bcd7b3de..6d3e46350 100644 --- a/pkg/porter/lifecycle.go +++ b/pkg/porter/lifecycle.go @@ -158,7 +158,7 @@ func (o *BundleExecutionOptions) defaultDriver(p *Porter) { // // When you run porter installation apply, there are some settings from porter install // that aren't exposed as flags (like driver and allow-docker-host-access). - // This allows the user to set them in the config file and we will use them before running the bundle. + // This allows the user to set them in the config file, and we will use them before running the bundle. // // Apply global config to the --driver flag diff --git a/pkg/porter/list.go b/pkg/porter/list.go index ae39c0e82..0111da446 100644 --- a/pkg/porter/list.go +++ b/pkg/porter/list.go @@ -179,7 +179,7 @@ func (d DisplayInstallation) ConvertToInstallation() (storage.Installation, erro return i, nil } -// ConvertParamToSet converts a Parameters into a internal ParameterSet. +// ConvertParamToSet converts a Parameters into an internal ParameterSet. func (d DisplayInstallation) ConvertParamToSet() (storage.ParameterSet, error) { strategies := make([]secrets.SourceMap, 0, len(d.Parameters)) for name, value := range d.Parameters { diff --git a/pkg/porter/publish.go b/pkg/porter/publish.go index 543e1c56e..b93c296c7 100644 --- a/pkg/porter/publish.go +++ b/pkg/porter/publish.go @@ -84,7 +84,7 @@ func (o *PublishOptions) validateTag() error { } // Publish is a composite function that publishes an invocation image, rewrites the porter manifest -// and then regenerates the bundle.json. Finally it publishes the manifest to an OCI registry. +// and then regenerates the bundle.json. Finally, it publishes the manifest to an OCI registry. func (p *Porter) Publish(ctx context.Context, opts PublishOptions) error { ctx, log := tracing.StartSpan(ctx) defer log.EndSpan() diff --git a/pkg/porter/reconcile.go b/pkg/porter/reconcile.go index b6a24a3ca..5bd3e9d11 100644 --- a/pkg/porter/reconcile.go +++ b/pkg/porter/reconcile.go @@ -145,7 +145,7 @@ func (p *Porter) IsInstallationInSync(ctx context.Context, i storage.Installatio } } - // We want to upgrade but we don't have values to compare against + // We want to upgrade, but we don't have values to compare against // This shouldn't happen but check just in case if lastRun == nil { log.Info("Triggering because the last run for the installation wasn't recorded")