Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sqflite tests #1806

Closed
wants to merge 1 commit into from
Closed

fix: sqflite tests #1806

wants to merge 1 commit into from

Conversation

buenaflor
Copy link
Contributor

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- sqflite tests ([#1806](https://github.com/getsentry/sentry-dart/pull/1806))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 49cd933

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1cdcacf) 91.13% compared to head (49cd933) 88.07%.

Files Patch % Lines
sqflite/lib/src/sentry_database.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   91.13%   88.07%   -3.07%     
==========================================
  Files         171        7     -164     
  Lines        5395      436    -4959     
==========================================
- Hits         4917      384    -4533     
+ Misses        478       52     -426     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


@override
Future<T> readTransaction<T>(Future<T> Function(Transaction txn) action) {
return transaction((txn) => action(txn));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed this in #1807. We need to call the internal _database.readTransaction for this to be correct, no?

@buenaflor
Copy link
Contributor Author

Fixed in #1807

@buenaflor buenaflor closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants