Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailspring #4962

Closed
1 of 2 tasks
clintre opened this issue Feb 3, 2025 · 6 comments
Closed
1 of 2 tasks

Mailspring #4962

clintre opened this issue Feb 3, 2025 · 6 comments
Labels
Package: Addition Request Please consider adding this to the repository Priority: Wishlist It would be nice to have State: Rejected Wontfix

Comments

@clintre
Copy link

clintre commented Feb 3, 2025

Please confirm there isn't an open request for this package

  • I have searched through package addition requests

Homepage

https://www.getmailspring.com

Maintainer

  • Would you like to be the maintainer for this package?

Why should this be included in the repository?

This is a solid email application that works better in some cases than Thunderbird due to its ability to handle multiple Exchange accounts, in an easy and direct manner. It brings a clean interface and offers options for users.

There is a third-party Flatpak that is not official. However, despite working with the maintainer, it does not work properly for many account types and is often behind the current version. There is a Snap version as well, but many people like to avoid Snaps on their system. The other official packages are RPM and Deb packages provided by the maintainer.

Are we allowed to redistribute it?

GPL v3

What kind of user will use this package, and how many users do you think will use this package?

Users with multiple email accounts and professional users who need a proper email client for Office 365 and others.

Link to source archive file

https://github.com/Foundry376/Mailspring/archive/refs/tags/1.15.1.tar.gz

@clintre clintre added Package: Addition Request Please consider adding this to the repository Priority: Wishlist It would be nice to have labels Feb 3, 2025
@github-project-automation github-project-automation bot moved this to Triage in Solus Feb 3, 2025
@EbonJaeger
Copy link
Member

It looks like it was deprecated from our repository with the reason:

Has major unresolved security issues, has a flatpak for those who don't care about that

@clintre
Copy link
Author

clintre commented Feb 3, 2025

Interesting, I know they have been working with security team to get security up to where it should be. But, would be curious to what the problem was and if it still exists.

@EbonJaeger
Copy link
Member

Yeah, someone with more knowledge than myself would have to take a look and see what the current situation is. If it is deemed safe, I don't see why it couldn't be re-included. Someone else may have more input.

@clintre
Copy link
Author

clintre commented Feb 7, 2025

So I researched this a bit more and found the old security issue from their earlier versions. Which was found and reported by Sonar. They were running on an outdated Electron version and had some open vulnerabilities, and at the time the project's development had slowed down. However, they did patch that and over the last year have really ramped up support and security patches. They have upgraded to the latest version of Electron and have brought on security experts to help on the security side.

I have also run the code through static analysis and did not find anything dangerous at this time. That is obviously only a high-level test.

https://github.com/Foundry376/Mailspring/releases

@ReillyBrogan
Copy link
Contributor

The issue is actually with the mailsync binary they use which is what performs all of the fetching and syncing of mailboxes in the background. It uses absolutely ancient versions of various libraries, and this has not been improved at all since I reported it to them (Foundry376/Mailspring-Sync#9). For instance it uses OpenSSL 1.1.0f which was released in May of 2017.

@TraceyC77 TraceyC77 added the State: Rejected Wontfix label Feb 9, 2025
@TraceyC77 TraceyC77 moved this from Triage to Done in Solus Feb 9, 2025
@TraceyC77
Copy link
Contributor

The security issues Reilly has raised need to be fixed before this can be considered for inclusion.

@malfisya malfisya closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Addition Request Please consider adding this to the repository Priority: Wishlist It would be nice to have State: Rejected Wontfix
Projects
Archived in project
Development

No branches or pull requests

5 participants