Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the sequencer sends "true" as a boolean to the websocket after every midi note ? #17

Open
JTriggerFish opened this issue Oct 21, 2018 · 1 comment

Comments

@JTriggerFish
Copy link

in seq.js:
scheduler.msgs.push( msg, priority > this.priority ? priority : this.priority )
priority is a boolean value of true in nearly all cases.
This ends up being send to the websocket, which probably ends up ignoring it or swallowing an exception ? ( haven't been able to figure out what it does with it )

Is this intentional ?

@JTriggerFish JTriggerFish changed the title the sequencer sends "true" as an boolean to the websocket after every midi note ? the sequencer sends "true" as a boolean to the websocket after every midi note ? Oct 21, 2018
@JTriggerFish
Copy link
Author

I notice that shouldExecute on sequencing objects is sometimes an integer and sometimes a boolean which I think is related.
I don't fully understand how it works though so I'm not sure what it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant