Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in responsiveness of navbar #288

Open
pooja2299 opened this issue Mar 31, 2021 · 7 comments · May be fixed by #315
Open

Issue in responsiveness of navbar #288

pooja2299 opened this issue Mar 31, 2021 · 7 comments · May be fixed by #315
Assignees
Labels

Comments

@pooja2299
Copy link

Explain what you did (Required)

I reduced the screen size to check the mobile responsiveness of the webpage of feminist bible.

Expected behavior (Required)

Navbar should collapse when reduced to mobile screen and expand when its desktop view.

Describe the bug (Required)

When reduced to mobile view the navbar doesn't collapse and all the dropdown elements are visible. It collapses when clicked on the toggler icon. After this, if we return back to desktop size the navbar does not appear at all. Does it suppose to work like this? Need your feedback.
If not then I would like to work on this.

To Reproduce (Required)

  • Steps
  1. Open the webpage
  2. Inspect the webpage in chrome - ctrl + shift + 'I'

image

  1. Click on the 'Toggle device toolbar' (second icon) in inspect menu.
  2. You would observe that dropdown menu is directly visible in the mobile view

image

  1. Now click on the toggle icon on the navbar (the navbar collapses).

image

  1. Switch back to desktop view - click 'Toggle device toolbar'
  2. The navbar elements does not appear.

image

@shashankmotruri
Copy link
Collaborator

@pooja2299 I think its a bug. please go ahead.

@gauravdas014 gauravdas014 added the bug Something isn't working label Apr 1, 2021
@pooja2299
Copy link
Author

Ok. Thanks!

@gauravdas014
Copy link
Collaborator

@pooja2299 What's the progress?

@pooja2299
Copy link
Author

Hi @gauravdas014 . I am not familiar with react js, so I was reading about it. Now I am working on the issue. My approach is to set the correct condition for navHidden so that it correctly shows navbar in both the screen.

@tanishq-arya
Copy link

@gauravdas014 Can I work on this along with @pooja2299 ?

@gauravdas014
Copy link
Collaborator

@tanishq-arya It's a very small issue. Please create some issue if you would like to work on.

@pooja2299 pooja2299 linked a pull request Apr 9, 2021 that will close this issue
pooja2299 added a commit to pooja2299/feminist-bible-phase-2 that referenced this issue Apr 13, 2021
pooja2299 added a commit to pooja2299/feminist-bible-phase-2 that referenced this issue Apr 17, 2021
pooja2299 added a commit to pooja2299/feminist-bible-phase-2 that referenced this issue Apr 17, 2021
@srishtij2000
Copy link

Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants