Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentifierHiddenSharedQuery broken on the next branch #749

Closed
jketema opened this issue Oct 16, 2024 · 2 comments
Closed

IdentifierHiddenSharedQuery broken on the next branch #749

jketema opened this issue Oct 16, 2024 · 2 comments
Assignees
@lcartey

Comments

@jketema
Copy link
Collaborator

jketema commented Oct 16, 2024 •
edited
Loading

We've made some improvements to getParentScope in the C/C++ QL library: github/codeql#17776

This has broken IdentifierHiddenSharedQuery on next: 2778d66. It's not fully clear to me what the query is supposed to achieve and how to fix it. Hence, I've just updated the expected test results.
@lcartey lcartey self-assigned this Oct 22, 2024
@lcartey
Copy link
Collaborator

lcartey commented Dec 10, 2024

@jketema I believe this should be addressed (incidentally) by #813, which implements the desired behaviour for that query in preference to the default getParentScope behaviour.

@lcartey lcartey closed this as completed Dec 10, 2024
@lcartey
Copy link
Collaborator

lcartey commented Dec 10, 2024

If you still see problems when you next merge main, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcartey lcartey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lcartey @jketema