Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint v9+ still uses the unsupported filenames plugin in the recommended extension #580

Closed
prince-chrismc opened this issue Nov 27, 2024 · 2 comments

Comments

@prince-chrismc
Copy link

prince-chrismc commented Nov 27, 2024

thank for the work on updating this , I saw #578 but I think there's at least one more reference to the plugin the recommended section

'filenames/match-regex': ['error', '^[a-z0-9-]+(.[a-z0-9-]+)?$'],

export default [{
    files: [
        "src/**/*.ts",
        "__tests__/**/*.ts",
    ],
    ignores: [
        "**/dist/",
        "**/lib/",
        "**/node_modules/",
        "**/jest.config.js",
    ],
}, ...compat.extends("plugin:github/recommended"), {
    plugins: {
        "@typescript-eslint": typescriptEslint,
    },

    languageOptions: {
        globals: {
            ...globals.node,
        },

        parser: tsParser,
        ecmaVersion: 2023,
        sourceType: "module",

        parserOptions: {
            project: "./tsconfig.json",
        },
    },
prince-chrismc added a commit to prince-chrismc/check-actor-permissions-action that referenced this issue Nov 27, 2024
@gracepark
Copy link
Contributor

What version are you on? We recently updated so that with ESLint v9 we brought the filenames rule into our plugin. But on legacy config we use the original filenames plugin.

@prince-chrismc
Copy link
Author

prince-chrismc commented Nov 29, 2024

I am using the latest 5.1.3

I am not a javascript developer but I did follow the eslint migration and believe I am using the new format for the config files. I just saw #539 which update the documentation. Following that I was able to get it working :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants