Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Passing no callback to request so as to retrieve a stream causes crash #5

Open
angadn opened this issue May 15, 2016 · 0 comments
Open

Comments

@angadn
Copy link

angadn commented May 15, 2016

I think https://github.com/gitterHQ/request-http-cache/blob/master/lib/index.js#L243 should be
callback && callback(null, response, body); - should this fix it? I'd have PRed, but not sure if the module would still work as expected/cache and return a stream from Redis/cache

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant