Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to change unit for water pressure #13

Open
pertakman opened this issue Feb 7, 2021 · 3 comments
Open

Suggestion to change unit for water pressure #13

pertakman opened this issue Feb 7, 2021 · 3 comments

Comments

@pertakman
Copy link

Thank you for the hard work you've put into making this custom integration!

I've been using it ever since you finished the switch to turn off the water when nobody is at home. It works great based on cell phone presence and security alarm state.

I had to upgrade to latest version yesterday when I upgraded Home Assistant. I realized today that you've added units to the pressure, but that you've chosen mbar instead of bar. It seems to me like bar is a more common unit for water pressure rather than mbar. I've changed the sensor.py file in my system manually to set it back to bar. If you think this makes sense you could change on your side as well.

Please disregard if mbar makes more sense to you!

Warmly, Per

@zuper83
Copy link

zuper83 commented Feb 12, 2022

Thank you for the hard work you've put into making this custom integration!

I've been using it ever since you finished the switch to turn off the water when nobody is at home. It works great based on cell phone presence and security alarm state.

I had to upgrade to latest version yesterday when I upgraded Home Assistant. I realized today that you've added units to the pressure, but that you've chosen mbar instead of bar. It seems to me like bar is a more common unit for water pressure rather than mbar. I've changed the sensor.py file in my system manually to set it back to bar. If you think this makes sense you could change on your side as well.

Please disregard if mbar makes more sense to you!

Warmly, Per

Per, may I friendly ask what changes you did in sensor.py to revert back to bar? I'm not so skilled.
Best regards
Markus

@pertakman
Copy link
Author

Hi Markus,

The file names sensor.py contains two occurrences the text "PRESSURE_MBAR". I simply replaced it with "PRESSURE_BAR". That works for me!

I've attached my modified version of the file.

Cheers, Per

sensor.zip

@zuper83
Copy link

zuper83 commented Feb 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants