Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examine isEmptyStruct and why it's necessary #30

Open
Schwartz10 opened this issue May 15, 2023 · 2 comments
Open

Examine isEmptyStruct and why it's necessary #30

Schwartz10 opened this issue May 15, 2023 · 2 comments

Comments

@Schwartz10
Copy link
Contributor

No description provided.

@Schwartz10 Schwartz10 mentioned this issue May 15, 2023
Merged
@lanzafame
Copy link
Contributor

I thought it was necessary because the current keystore.GetAddrs implementation can return an "empty", i.e. address.Address{}, with a nil error value, but now that I look at it, that seems to be incorrect.

@lanzafame
Copy link
Contributor

I will leave this as is until the new wallet stuff lands and based on how that plays out will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lanzafame @Schwartz10