Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining illegal colon in ID #751

Closed
1313ou opened this issue Sep 10, 2021 · 1 comment
Closed

Remaining illegal colon in ID #751

1313ou opened this issue Sep 10, 2021 · 1 comment
Labels
release format This issue refers to the WNDB or RDF export, so no changes will be made to this repository
Milestone

Comments

@1313ou
Copy link
Contributor

1313ou commented Sep 10, 2021

[E] attribute "id" has a bad value: "ewn-capital:critique_of_political_economy__1_10_01_" does not satisfy the "ID" type [row,col,system-id]: [47060,7,"file:src/xml/wn-noun.communication.xml"]

This colon however is not a field separator in the sense key but part of the lemma. This is the only instance of this happening in a lemma and has already been noted as strange. Unless specific escaping is applied, it makes this sense key unparseable.

@1313ou 1313ou added the release format This issue refers to the WNDB or RDF export, so no changes will be made to this repository label Sep 10, 2021
@ekaf
Copy link
Contributor

ekaf commented Sep 10, 2021

If this ID is unparseable, this issue is also relevant for #747.

This lemma refers to the seminal book by Karl Marx. The part after the colon is the book's subtitle, and should not necessarily be included. Or maybe the synset could include both the short form, and the long form with the colon escaped or replaced by a comma.

@jmccrae jmccrae added this to the 2021 Release milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release format This issue refers to the WNDB or RDF export, so no changes will be made to this repository
Projects
None yet
Development

No branches or pull requests

3 participants