Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dialog should be extracted into a non-intrusive notification #489

Open
2 tasks
AlmasB opened this issue Jan 23, 2022 · 4 comments · May be fixed by #519
Open
2 tasks

Update dialog should be extracted into a non-intrusive notification #489

AlmasB opened this issue Jan 23, 2022 · 4 comments · May be fixed by #519
Assignees
Labels
enhancement New feature or request

Comments

@AlmasB
Copy link
Collaborator

AlmasB commented Jan 23, 2022

Expected Behavior

  • Update notification is shown elsewhere in the SB workflow
  • It also seems the "Check for Updates..." menu item crashes

Current Behavior

Update dialog is shown if necessary at the end of welcome dialog workflow

Context

@AlmasB AlmasB added the enhancement New feature or request label Jan 23, 2022
@AlmasB AlmasB self-assigned this Jan 23, 2022
@paul-court
Copy link
Contributor

For the "It also seems the Check for Updates... menu item crashes", are you referring to every now and again it just doesn't seem to do anything?

@paul-court
Copy link
Contributor

paul-court commented Feb 20, 2022

I found that the if/else code branch when version was up-to-date was not wrapping the call to display the alert in Platform.runLater() - So I've pushed a quick fix for that here

Do you want to take that as a separate fix?

Otherwise, given this is an enhancement, I am also seeing a lot of duplicated code that can probably be re-factored and I'm also not sure why all this logic needs to be in SceneBuilderApp anyway. Am I missing some design pattern or something (I'm very new to desktop programming in general and still finding my feet with Java and JavaFX).

I was thinking all the update logic could be rolled into an overhauled "About" dialog which I have some ideas about and was going to start a discussion topic on.

Am I going too deep with this?

@AlmasB
Copy link
Collaborator Author

AlmasB commented Feb 20, 2022

For this issue, fixing the above two check boxes is sufficient. Visually, I'd probably go for a red dot / circle near "Update" in the menu bar to indicate that an update is available.

About and update dialogs should probably stay separate.

As for refactoring, I'm in the middle of #473 so don't worry too much about the architecture of existing code -- it will be updated.

@paul-court
Copy link
Contributor

OK. I see what I can do to add a visual indicator.

@AlmasB AlmasB assigned paul-court and unassigned AlmasB Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants