Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.6 #11

Open
mph88 opened this issue Oct 2, 2018 · 1 comment
Open

Python 3.6 #11

mph88 opened this issue Oct 2, 2018 · 1 comment

Comments

@mph88
Copy link

mph88 commented Oct 2, 2018

Thanks for the great work you did with this program. I wanted to make your version work under py3.6, so there were a couple of changes I noticed. I'm using the py3 fork of pycarwings2 by BenWoodford.

lower case on ConfigParser in line5:
from configparser import SafeConfigParser

The mqtt message to run get_leaf_update or climate_control was not working due to the change in bytes/strings. In line 56, should be:
logging.info(msg.topic+" "+msg.payload.decode('UTF-8'))

By the same token in line 59:
control_message = msg.payload.decode('UTF-8')

I don't know if these break your version for py2 as I didn't test.

@filcole
Copy link
Contributor

filcole commented Jan 5, 2019

Hi @mph88,

I've made another fork of pycarwings2, supporting python3 and with a few other bug fixes, see https://github.com/filcole/pycarwings2. I've uploaded it to PyPi to make it easy to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants