Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-revoke token approvals on submit page #61

Open
jfschwarz opened this issue Feb 8, 2023 · 1 comment
Open

Auto-revoke token approvals on submit page #61

jfschwarz opened this issue Feb 8, 2023 · 1 comment

Comments

@jfschwarz
Copy link
Collaborator

jfschwarz commented Feb 8, 2023

When submitting a batch that includes any ERC20 token approvals we should allow the user to revoke all given approvals at the end of the batch.

It should actually be the default behavior: A checkbox revoke all token approvals should be pre-selected by default. Next to the checkbox label we should display an info bubble (i) that on hover shows the following explanation:

The transaction bundle you are about to submit includes token approvals, which grant certain dApps permission to spend your tokens. If you don’t revoke these approvals, the dApps will retain the ability to spend your tokens indefinitely. Maintain full control by atomically revoking any leftover approval balances as a final step in the transaction.

The checkbox should not be displayed if there are no approvals in the batch.

Approvals should be detected based on transaction event logs (Approval(address owner, address spender, uint256 value) event).

If the checkbock is selected, upon submit it should add the required extra calls to the bundle to be passed for signing. These calls should not appear in the right panel for now.

@auryn-macmillan
Copy link
Member

This is a really nice feature idea!

@jfschwarz jfschwarz changed the title Idea: add option to revoke approvals Idea: add option to revoke approvals on submit page Feb 28, 2025
@jfschwarz jfschwarz changed the title Idea: add option to revoke approvals on submit page Auto-revoke token approvals on submit page Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants