Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to test and handle workloadRef #6

Open
gnunn1 opened this issue Jul 21, 2023 · 1 comment
Open

Need to test and handle workloadRef #6

gnunn1 opened this issue Jul 21, 2023 · 1 comment

Comments

@gnunn1
Copy link
Contributor

gnunn1 commented Jul 21, 2023

Right now this UI has only been tested when the rollout includes the pod template, however the rollout can also reference a workloadRef in Deployments, Replicasets, etc and there are some changes in behavior required when this done.

For example, a rollback needs to replace the template in the dependent object rather then in the rollout as per this code here:

https://github.com/argoproj/argo-rollouts/blob/master/pkg/kubectl-argo-rollouts/cmd/undo/undo.go#L117

There are likely other places where this will cause issues.

@gnunn1
Copy link
Contributor Author

gnunn1 commented Jul 22, 2023

Actually rollback may be the only place where anything special needs to happen, interestingly the existing Argo Rollouts UI has zero support for workloadRef as there is no mention of it beyond 1 line in the generated API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant