You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now this UI has only been tested when the rollout includes the pod template, however the rollout can also reference a workloadRef in Deployments, Replicasets, etc and there are some changes in behavior required when this done.
For example, a rollback needs to replace the template in the dependent object rather then in the rollout as per this code here:
Actually rollback may be the only place where anything special needs to happen, interestingly the existing Argo Rollouts UI has zero support for workloadRef as there is no mention of it beyond 1 line in the generated API.
Right now this UI has only been tested when the rollout includes the pod template, however the rollout can also reference a workloadRef in Deployments, Replicasets, etc and there are some changes in behavior required when this done.
For example, a rollback needs to replace the template in the dependent object rather then in the rollout as per this code here:
https://github.com/argoproj/argo-rollouts/blob/master/pkg/kubectl-argo-rollouts/cmd/undo/undo.go#L117
There are likely other places where this will cause issues.
The text was updated successfully, but these errors were encountered: