Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static keyword on GlowGetProcAddress instead of unique suffix. #88

Closed
dmitshur opened this issue Sep 20, 2017 · 0 comments · Fixed by #123
Closed

Use static keyword on GlowGetProcAddress instead of unique suffix. #88

dmitshur opened this issue Sep 20, 2017 · 0 comments · Fixed by #123

Comments

@dmitshur
Copy link
Member

dmitshur commented Sep 20, 2017

This is a simple cleanup task. It's a good first contribution for anyone interested in taking it.

In #87, GlowGetProcAddress was given a per-package unique suffix to fix go-gl/gl#85.

In go-gl/gl#85 (comment), @errcw realized that:

In retrospect it occurs to me that an equivalent fix might have been to mark the C functions as static (which, I realize now, is why the GL definitions do not experience the same conflict)

Since that approach is slightly simpler, we can update our code to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant