Charsets in the DSN Config is lowercase and cannot be used

[modelorona]

mysql/dsn.go

Line 47 in 85c6311

charsets []string // Connection charset. When set, this will be set in SET NAMES <charset> query

Based on the README docs, shouldn't this be capitalized as to let it be used?

[methane]

I don't like the charsets list.
I will provide functional option for charset.

[modelorona]

Cool, thanks :)

[methane]

charset can be list. e.g. "utf8,utf8mb4,utf8mb3". In this case, user can not specify collation. Should we provide a way to multiple charset/collation pair? I don't want to do...

My current idea is:

// Charset sets charsets and collation.
//
// When collate is empty, server's default collation is used. (e.g. `SET NAMES <charset>`.)
// Otherwise, both of charset and collate is used. (e.g. `SET NAMES <charset> COLLATE <collate>`.)
func Charset(charset, collation string) Option

Should this charset supports comma separated charsets?