Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When ESM styled store.ts used then no way to export makeStore to be properly consumed by @gasket/plugin-redux->middleware #1025

Open
sdzialowski-godaddy opened this issue Jan 30, 2025 · 0 comments

Comments

@sdzialowski-godaddy
Copy link

sdzialowski-godaddy commented Jan 30, 2025

🐛 Bug Report

Image

when ESM used ("type":"module" in package.json) there is no way to export properly makeStore() to make it ready to be consumed by
node_modules/@gasket/plugin-redux/lib/middleware.js because instead of

    const store = makeStore(initState, {
      logger: reduxConfig.logger || gasket.logger,
      req
    });

it would need to execute

    const store = makeStore.default(initState, {
      logger: reduxConfig.logger || gasket.logger,
      req
    });

To Reproduce

Expected Behavior

Code Example

Environment

@sdzialowski-godaddy sdzialowski-godaddy changed the title @gasket/plugin-redux when store.ts then no way to export makeStore to be properly consumed by @gasket/plugin-redux->middleware @gasket/plugin-redux when store.ts used then no way to export makeStore to be properly consumed by @gasket/plugin-redux->middleware Jan 31, 2025
@sdzialowski-godaddy sdzialowski-godaddy changed the title @gasket/plugin-redux when store.ts used then no way to export makeStore to be properly consumed by @gasket/plugin-redux->middleware @gasket/plugin-redux when ESM styled store.ts used then no way to export makeStore to be properly consumed by @gasket/plugin-redux->middleware Jan 31, 2025
@sdzialowski-godaddy sdzialowski-godaddy changed the title @gasket/plugin-redux when ESM styled store.ts used then no way to export makeStore to be properly consumed by @gasket/plugin-redux->middleware When ESM styled store.ts used then no way to export makeStore to be properly consumed by @gasket/plugin-redux->middleware Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant