Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Crashing without MetaMask Account #1

Open
kysley opened this issue Dec 20, 2018 · 1 comment
Open

App Crashing without MetaMask Account #1

kysley opened this issue Dec 20, 2018 · 1 comment
Assignees

Comments

@kysley
Copy link

kysley commented Dec 20, 2018

Expected Behavior

Step 1 should indicate error (or incomplete state) when MetaMask is closed when the user is prompted to login.

Current Behavior

Step 1 indicates success & app proceeds to crash once the user clicks 'Send to Bridge'

Possible Solution

(Quick Solution): Wrap the routes inside an ErrorBoundary Component which catches the crash and tells the user to reload.
(Better Solution): Include the above as a catch-all + check to make sure that we have access to MetaMask instead of assuming.

Steps to Reproduce

  1. Open http://goerli.com/bridge
  2. Close MetaMask popup (without logging in)
  3. Enter any amount
  4. Hit 'Send to Bridge'

Detailed Description

PR including both possible solutions + misc styling improvements.

Possible Implementation

See PR coming soon.

@chrisfenos
Copy link
Contributor

seems to be the issue - MetaMask/metamask-extension#4434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants