improve robot access token file format

[toxeus]

After creating a new robot account it's possible to download the generated token as a file. Unfortunately, the JSON formatting doesn't allow the file to be used seamlessly with

docker login --password-stdin < 'robot$something.json'

.

A clear improvement would be if the file would contain the access token exclusively.
The proposed change is trivial to implement.

[rrgadeev]

cat robot$project+test.json | jq .secret

[rrgadeev]

docker login harbor.domainname.local --username $(jq -r .name robot$project+test.json) --password $(jq -r .secret robot$project+test.json)

[toxeus]

Yes, I know about jq. But this tool is not installed by default on most distros. I'm distributing the robot files to third parties and it would be great if it would just work out-of-the-box instead of me explaining to them how to install and use jq correctly.

Also, your code snippets are wrong: you didn't escape $ so everything following it will be interpreted as an env var name and expanded to an empty string since those env vars are most likely undefined. That nicely supports my argument above.

Using $ in the user and filename is another design choice (orthogonal to this one) that impacts UX for no reason that is apparent to me. But I'm hesitant to open an issue about that one since fixing it impacts backwards compatibility for existing user names.

[rrgadeev]

Yes, I know about jq. But this tool is not installed by default on most distros. I'm distributing the robot files to third parties and it would be great if it would just work out-of-the-box instead of me explaining to them how to install and use jq correctly.

Also, your code snippets are wrong: you didn't escape $ so everything following it will be interpreted as an env var name and expanded to an empty string since those env vars are most likely undefined. That nicely supports my argument above.

Using $ in the user and filename is another design choice (orthogonal to this one) that impacts UX for no reason that is apparent to me. But I'm hesitant to open an issue about that one since fixing it impacts backwards compatibility for existing user names.
it works, $() - https://stackoverflow.com/questions/27472540/difference-between-and-in-bash
I think if people can use docker, they can also use jq

[toxeus]

Thx for re-confirming my argument 😊

[rrgadeev]

[rrgadeev]

you are right, there itself was escaped in the process of pressing tab, I forgot ``

[rrgadeev]

docker login harbor.domainname.local --username $(jq -r .name robot\$project+test.json) --password $(jq -r .secret robot\$project+test.json)

[toxeus]

I guess from the discussion we just had now everyone can understand how guiding of third-parties can look like. Yes, we eventually manage to make it work. But the more such cases I have the more time-consuming it is.

If there's no good reason for the current file format then I'd change it to enable a better out-of-the-box experience. I'm surprised that this is controversial since it should be in the interest of the project to improve UX.

[phin1x]

I would disagree that changing the file format would improve UX. Exporting the robot data in json you have the username and the token in one file (better for distributing), the credentials are better to parse (like the docker login example above) and with jq they are easy to read. nowadays jq is part of the standard toolchain.

Whether it is better to export the information as plain text or as json, depends then nevertheless strongly on the use case and the personal opinion. i prefer the json format.

[ninjadq]

Convert it discussion as per there are a lot of discuss