Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not wait on zero retries #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not wait on zero retries #94

wants to merge 1 commit into from

Conversation

greut
Copy link

@greut greut commented Sep 16, 2020 •
edited
Loading

Closes #89 , /cc @xyluet

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.9%) to 91.105% when pulling 560faa3 on greut:fix/wait-when-no-retries into 2f1fd27 on gojek:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.9%) to 91.105% when pulling 560faa3 on greut:fix/wait-when-no-retries into 2f1fd27 on gojek:master.

@sunjayaali
Copy link

Better to add test, an example from my issue should enough, then let the maintainer decide. 👍

@greut
Copy link
Author

greut commented Sep 16, 2020

ExampleWithRetrier is the test.

Panlq pushed a commit to Panlq/heimdall that referenced this pull request Apr 6, 2022
fix issue gojek#89/gojek#94: retrier called even with 0 retry count a…
ea25c41 
…nd tiem sleep will be called even when the retries are exhausted
@Panlq Panlq mentioned this pull request Apr 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrier called even with 0 retry count
3 participants
@greut @coveralls @sunjayaali