Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue while uploading large files using heimdall client #96

Open
nrmaridu opened this issue Oct 25, 2020 · 0 comments
Open

Comments

@nrmaridu
Copy link

nrmaridu commented Oct 25, 2020

if request.Body != nil {
reqData, err := ioutil.ReadAll(request.Body)
if err != nil {
return nil, err
}
bodyReader = bytes.NewReader(reqData)
request.Body = ioutil.NopCloser(bodyReader) // prevents closing the body between retries
}
The above piece of code form client.go is using ioutil.ReadAll to read all data from reqeust body. Doesn't that process have performance issue while uploading large files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant