Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for equivalent paths for watch option #1895

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

joelim-work
Copy link
Collaborator

@joelim-work joelim-work commented Jan 17, 2025

Changes:

  • Whenever a watched directory receives an event from fsnotify, updates are now additionally sent to other watched directories that are equivalent (i.e. point to the same inode, for example bind mounts).
  • The logic for watching directories is simplified. Now instead of calculating which paths to watch whenever the changing directories (e.g. using the updir/open/cd commands), directories will now be watched whenever it is loaded (i.e. added to the directory cache).

@joelim-work joelim-work marked this pull request as draft January 17, 2025 00:51
@joelim-work joelim-work marked this pull request as ready for review January 28, 2025 23:29
@joelim-work joelim-work merged commit 7595e05 into gokcehan:master Jan 29, 2025
4 checks passed
@joelim-work joelim-work deleted the watch-same-paths branch January 29, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing file update after paste
1 participant