Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisparr support #127

Open
KyleSanderson opened this issue Sep 9, 2023 · 6 comments
Open

Whisparr support #127

KyleSanderson opened this issue Sep 9, 2023 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@KyleSanderson
Copy link

Hello,

The Whisparr team was kind enough to let us know that they've changed from the Radarr API to the Sonarr API with V2 of their application. I was wondering if there could be an explicit interface added to integrate with this application (even if it's just a name ptr) so for future integration purposes/changes it can be handled upstream (this library). I think this is the only arr application that's not in here presently.

@austinwbest
Copy link
Collaborator

Nothing has been done in regards to whisparr for this or unpackerr or notifiarr (all are projects that use it and that captain maintains) until the api was in a much more stable place change wise. I'll talk to to Q about it.

@austinwbest
Copy link
Collaborator

After speaking with Q, there are still some API adjustments to be made in regards to movies as well. As it was not fun trying to keep an actively developed API running (this was done with Readarr awhile back and was a lot of work for captain to implement and me to test/track the api changes with TA) i would think it is fair to say this would still be on hold a little longer.

@KyleSanderson
Copy link
Author

After speaking with Q, there are still some API adjustments to be made in regards to movies as well. As it was not fun trying to keep an actively developed API running (this was done with Readarr awhile back and was a lot of work for captain to implement and me to test/track the api changes with TA) i would think it is fair to say this would still be on hold a little longer.

Understood. autobrr's usecase feels simple around submission: is it possible to expose an experimental endpoint for Whisparr (cloning sonarr as-is with the interface copy) until such a time it's stabilized for the product.

"No." is okay, but I thought I'd ask as it still keeps the door open to iterate / hack on while downstream continues to reep the benefits of starr (without hard coding Sonarr for Whisparr).

@davidnewhall
Copy link
Contributor

(even if it's just a name ptr)

Shouldn't be a problem.

@davidnewhall davidnewhall added enhancement New feature or request good first issue Good for newcomers labels Sep 11, 2023
@davidnewhall
Copy link
Contributor

Honestly, Kyle, if you want to make a PR that adds the stub, I'll take a look. I'm not entirely sure the best way to do it.

@davidnewhall
Copy link
Contributor

For what it's worth, I just alias Whisparr to Radarr or Sonarr in my apps. Really doesn't matter which at this point, and maybe even both for some features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants