fix: Improve menu mouse/keyboard selection interaction. #8749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
This PR updates the menu to check if the pointer has actually moved before selecting the hovered menu item in response to an alleged pointer move event. Previously, it was listening for
pointerover
events, and selecting the hovered menu item. In the case where the user has their pointer over the menu, and is scrolling through the list of menu items via the up/down arrows, the menu items will scroll into view when the selection reaches the beginning/end of the visible set of menu items. This movement of elements under the pointer causes apointerover
event to fire, even though the pointer has been stationary, which had the effect of jumping the selection backwards to whatever menu item was under the pointer.Although
pointerover
events havemovementX
/movementY
properties, these are unpopulated (at least in Chrome), so I changed the code to listen forpointermove
instead, which does populate them. This allows checking whether the event was triggered due to movement, and disregarding it if not.Experimentally, this gives the desired behavior in Chrome/Safari/Firefox: moving the pointer highlights the corresponding menu items, but keyboard navigation takes precedence for navigating through menu items, until such time as the pointer is actually moved.
I also updated the field names to reference "pointer" instead of "mouse" since they were all private.
Additionally, this PR fixes an issue that caused menus to lose focus when the pointer exited their bounds.