diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0418df3281a..2c427f24d96 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -203,7 +203,7 @@ jobs: steps: - uses: actions/checkout@v3 - name: Setup .NET Core SDK - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4.2 with: dotnet-version: '8.0.x' - name: Build @@ -211,7 +211,7 @@ jobs: cd tests\FlatBuffers.Test dotnet new sln --force --name FlatBuffers.Test dotnet sln FlatBuffers.Test.sln add FlatBuffers.Test.csproj - dotnet build -c Release ${{matrix.configuration}} -o out FlatBuffers.Test.sln + dotnet build -c Release ${{matrix.configuration}} --property:PublishDir=out FlatBuffers.Test.sln - name: Run run: | cd tests\FlatBuffers.Test diff --git a/docs/source/building.md b/docs/source/building.md index e61a32c359b..de224c6d0ed 100644 --- a/docs/source/building.md +++ b/docs/source/building.md @@ -34,6 +34,20 @@ Use `cmake` to configure a project based on your environment and platform. cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Release ``` +#### Strict Mode + +By default, `cmake` will configure targets to **not** build with strict warnings +on (e.g. `-Werror` or `/WX`). This may cause into issues when submitting code +changes since our CI requires the code to compile in strict mode. + +To enable the extra warnings, turn on strict mode with the +`FLATBUFFERS_STRICT_MODE` cmake option. + +```cmake +cmake -DFLATBUFFERS_STRICT_MODE=ON +``` + + ### Building Once the project files are generated, build as normal for your platform. @@ -56,6 +70,11 @@ Once the project files are generated, build as normal for your platform. xcodebuild -toolchain clang -configuration Release ``` + + + + + ## Building with Bazel ## Building with VCPKG