Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSP2: KSClassDeclaration.getSealedSubclasses for symbols defined in sources #1643

Closed
ting-yuan opened this issue Dec 4, 2023 · 7 comments
Closed

KSP2: KSClassDeclaration.getSealedSubclasses for symbols defined in sources #1643

ting-yuan opened this issue Dec 4, 2023 · 7 comments
Assignees
@neetopia
Labels
P1 major features or blocking bugs
Milestone
2.0

Comments

@ting-yuan
Copy link
Collaborator

No description provided.

@ting-yuan ting-yuan added this to the 2.0 milestone Dec 4, 2023
@ZacSweers ZacSweers mentioned this issue Feb 3, 2024
Merged
@ting-yuan ting-yuan added the P1 major features or blocking bugs label Feb 27, 2024
@neetopia
Copy link
Contributor

should be fixed in next compiler version update per https://youtrack.jetbrains.com/issue/KT-66013/Analysis-API-Standalone-Sealed-inheritors-arent-correctly-calculated-for-source-classes

@neetopia
Copy link
Contributor

neetopia commented Apr 1, 2024

it is fixed by latest compiler update.

@neetopia neetopia closed this as completed Apr 1, 2024
@ZacSweers
Copy link
Contributor

ZacSweers commented Apr 5, 2024 •
edited
Loading

I'm still seeing 0 sealed subclasses returned in 2.0.0-Beta5-1.0.20. Repro is this PR: ZacSweers/MoshiX#510, where you can run the tests in MoshiProguardGenSymbolProcessorTest and breakpoint line 163 in MoshiProguardGenSymbolProcessor.kt

@neetopia
Copy link
Contributor

neetopia commented Apr 5, 2024

Thanks for the repo, I will investigate it.

@neetopia neetopia reopened this Apr 5, 2024
@neetopia
Copy link
Contributor

has there been any changes to moshix regarding the test mentioned in this issue? I tried to pull the PR to my local and MoshiProguardGenSymbolProcessorTest is passing for me.

@ZacSweers
Copy link
Contributor

It seems to be working now, I'm not sure what changed. Sorry forgot to update here!

@neetopia
Copy link
Contributor

Thanks for confirming, I will close this issue since it is resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neetopia neetopia

Labels
P1 major features or blocking bugs
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@ZacSweers @ting-yuan @neetopia