From d7af23135e06af14db98963da8097770652ec440 Mon Sep 17 00:00:00 2001 From: Emmett Lalish Date: Thu, 24 Oct 2024 15:58:21 -0700 Subject: [PATCH] update CDN to v4.0 (#4920) --- packages/model-viewer/README.md | 2 +- packages/modelviewer.dev/data/faq.json | 2 +- packages/modelviewer.dev/examples/twitter/player.html | 2 +- packages/modelviewer.dev/index.html | 2 +- packages/space-opera/src/components/best_practices/constants.ts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/model-viewer/README.md b/packages/model-viewer/README.md index bcb017cb7e..0313eb82b8 100644 --- a/packages/model-viewer/README.md +++ b/packages/model-viewer/README.md @@ -32,7 +32,7 @@ npm install @google/model-viewer It can also be used directly from various free CDNs such as [jsDelivr](https://www.jsdelivr.com/package/npm/@google/model-viewer) and Google's own [hosted libraries](https://developers.google.com/speed/libraries#model-viewer): ```html - + ``` For more detailed usage documentation and live examples, please visit our docs diff --git a/packages/modelviewer.dev/data/faq.json b/packages/modelviewer.dev/data/faq.json index 88d7680222..084d461fb2 100644 --- a/packages/modelviewer.dev/data/faq.json +++ b/packages/modelviewer.dev/data/faq.json @@ -86,7 +86,7 @@ { "name": "How should I access <model-viewer>?", "htmlName": "cdn", - "description": "If you control your own hosting, the safest option is always to host model-viewer.min.js yourself on the same server as your site. For smaller sites and blogs, it is often more convenient to use one of various free CDNs - Google provides <model-viewer> as one of its hosted libraries, which we recommend as it is a fast and reliable CDN. Simply specify your desired version in the URL: https://ajax.googleapis.com/ajax/libs/model-viewer/3.5.0/model-viewer.min.js. We used to recommend unpkg, but it has had several serious outages recently. It can automatically pick the most recent version, but this is not a good practice as it slows loading (two requests) and ideally you should test when updating to ensure no bugs have been introduced. Another good option is jsDelivr.", + "description": "If you control your own hosting, the safest option is always to host model-viewer.min.js yourself on the same server as your site. For smaller sites and blogs, it is often more convenient to use one of various free CDNs - Google provides <model-viewer> as one of its hosted libraries, which we recommend as it is a fast and reliable CDN. Simply specify your desired version in the URL: https://ajax.googleapis.com/ajax/libs/model-viewer/4.0.0/model-viewer.min.js. We used to recommend unpkg, but it has had several serious outages recently. It can automatically pick the most recent version, but this is not a good practice as it slows loading (two requests) and ideally you should test when updating to ensure no bugs have been introduced. Another good option is jsDelivr.", "links": [ "Google Hosted Libraries", "jsDelivr" diff --git a/packages/modelviewer.dev/examples/twitter/player.html b/packages/modelviewer.dev/examples/twitter/player.html index 57e0c257b8..d13ce59226 100644 --- a/packages/modelviewer.dev/examples/twitter/player.html +++ b/packages/modelviewer.dev/examples/twitter/player.html @@ -22,7 +22,7 @@ - + + diff --git a/packages/space-opera/src/components/best_practices/constants.ts b/packages/space-opera/src/components/best_practices/constants.ts index 72a8d57b1c..bd140fd1a6 100644 --- a/packages/space-opera/src/components/best_practices/constants.ts +++ b/packages/space-opera/src/components/best_practices/constants.ts @@ -28,7 +28,7 @@ export const modelViewerTemplate = ` REPLACEME - + `;