Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSS] Add pre-commit script to check for invalid inclusions. #1984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[OSS] Add pre-commit script to check for invalid inclusions. #1984

wants to merge 2 commits into from
+98 −5

Conversation

cdleary
Copy link
Collaborator

@cdleary cdleary commented Mar 6, 2025

Fixes #1976

@cdleary cdleary requested a review from meheff March 6, 2025 16:53
@cdleary cdleary force-pushed the cdleary/2025-03-06-pre-commit-relative-headers branch from ab1f721 to 0592635 Compare March 6, 2025 16:56
@cdleary cdleary force-pushed the cdleary/2025-03-06-pre-commit-relative-headers branch from 0592635 to da457e9 Compare March 6, 2025 17:01
meheff
meheff approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@meheff meheff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Chris!

@meheff meheff mentioned this pull request Mar 6, 2025
Open
@cdleary
Copy link
Collaborator Author

cdleary commented Mar 8, 2025

@meheff added pylint in this one too and fixed the issues it flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meheff meheff meheff approved these changes

Assignees
No one assigned
Labels
Reviewing Internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check for #include of header file without path
2 participants
@cdleary @meheff