Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test code related to PUBSUB_EMULATOR_HOST from client.py #1349

Open
ohmayr opened this issue Jan 24, 2025 · 0 comments
Open

Remove test code related to PUBSUB_EMULATOR_HOST from client.py #1349

ohmayr opened this issue Jan 24, 2025 · 0 comments
Assignees
@mukund-ananthu
Labels
api: pubsub Issues related to the googleapis/python-pubsub API.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Jan 24, 2025

Currently, the emulator code (for testing purposes) is set in client.py i.e. if PUBSUB_EMULATOR_HOST is set:

  • api endpoint is set to the PUBSUB_EMULATOR_HOST.
  • credentials are set to AnonymousCredentials.
  • channel is set to insecure_channel.

Remove this code from the client files and include it in the test files directly. The exact code location can be looked up by searching for this issue.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jan 24, 2025
@parthea parthea mentioned this issue Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ohmayr @mukund-ananthu