Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS enabled on ping service #3945

Open
Orgil opened this issue Aug 13, 2024 · 7 comments
Open

CORS enabled on ping service #3945

Orgil opened this issue Aug 13, 2024 · 7 comments
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones stale Pending closure unless there is a strong objection.

Comments

@Orgil
Copy link

Orgil commented Aug 13, 2024

Is your feature request related to a problem? Please describe.
checking ping from browser raises CORS issue.

Describe the solution you'd like
Enable CORS on ping service

@Orgil Orgil added the kind/feature New features for Agones label Aug 13, 2024
Copy link

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Dec 15, 2024
@markmandel
Copy link
Collaborator

🤔 on one hand, I'm wondering if we should do this... on the other, it feels like this should maybe be something a proxy or load balancer does? Not sure. 🤔

@github-actions github-actions bot removed the stale Pending closure unless there is a strong objection. label Jan 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Feb 1, 2025
@Orgil
Copy link
Author

Orgil commented Feb 1, 2025

i my case, to overcome cors issue, i had to put a load balancer just for ping service over every regional cluster.

@markmandel
Copy link
Collaborator

i my case, to overcome cors issue, i had to put a load balancer just for ping service over every regional cluster.

How else where you exposing the ping service, if not without a LB?

@Orgil
Copy link
Author

Orgil commented Feb 2, 2025

i forgot it what exactly happened, but i had to setup extra nginx on top of provider LB to solve cors. Maybe it was issue with cloud provider.

@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Feb 2, 2025
@markmandel
Copy link
Collaborator

Seems like a small fix to implement. Would love a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones stale Pending closure unless there is a strong objection.
Projects
None yet
Development

No branches or pull requests

2 participants