Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When you have a bad key, the message is not informative and there is an error on the page #361

Open
RobertLRead opened this issue Dec 10, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@RobertLRead
Copy link
Collaborator

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

Go here, which is a valid URL with an "x" appended:
https://gosqas.org/provenance/8FFYE6suyVbCtVAWe2sP8Yx

It says it loads forever.

Then go here:

https://gosqas.org/provenance/8FFYE6suyVbCtVAWe2sP8Y

And see the difrerence.

Note it thows an error on the page (bad promise) that you can see in the debugging tools:

Screenshot 2024-12-09 at 7 54 31 PM

Expected behavior
We should give an informative message saying "This is not a valid history key", and suggesting they go to a our home page, with a link provided.

Screenshots
If applicable, add screenshots to help explain your problem.
https://gosqas.org/provenance/8FFYE6suyVbCtVAWe2sP8Y

Desktop (please complete the following information):
Chrome browser, from a Mac omputer.

@RobertLRead RobertLRead added the bug Something isn't working label Dec 10, 2024
@RobertLRead
Copy link
Collaborator Author

@ninalahoti can you design a simple page for this and then assign it to Ben to assign to a developer?

@bencoombs
Copy link
Collaborator

The device page catches that error so we could do the same on the provenance page?
image

@ninalahoti
Copy link
Collaborator

@vjaqua
Copy link
Collaborator

vjaqua commented Dec 13, 2024

One text edit:
In place of the word "email" just say the email [email protected]

@ninalahoti
Copy link
Collaborator

Made the edit! @bencoombs I believe this is ready to be assigned now

@vjaqua
Copy link
Collaborator

vjaqua commented Feb 4, 2025

This would resolve #386 and #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Prioritized/Ready
Development

No branches or pull requests

4 participants