Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change http_req_failed line in output summary #24

Open
nicolevanderhoeven opened this issue Mar 11, 2021 · 1 comment
Open

Change http_req_failed line in output summary #24

nicolevanderhoeven opened this issue Mar 11, 2021 · 1 comment

Comments

@nicolevanderhoeven
Copy link

The check and cross on the http_req_failed line is the opposite of what I expected. The number after the check actually refers to responses where http_req_failed is true, whereas I expected ✓ to mean "HTTP code as expected" and ✗ to mean "HTTP code not as expected".

I think this is confusing and suggest either flipping that behavior or clarifying with "y failed z expected".

image

@na--
Copy link
Member

na-- commented Mar 11, 2021

I would be confusing if we just flip the ✓ and ✗ meanings, but maybe we can have some text like this: 25.00% (523 out of 2092 requests failed)

I'd prefer we do this by adding a callback per key option for generateTextSummary(): https://github.com/k6io/jslib.k6.io/blob/b2f64e18d6ffb636e34b6dbc2702b5c050243518/lib/k6-summary/0.0.1/index.js#L374-L375

And having a default hook for http_req_failed that would print our custom Rate text. That way users can re-use it for printing their own metrics in a custom manner, or for removing certain metrics out of the summary altogether, while still having the the jslib code handle the majority of the work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants