Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the summary jslib in a dedicated repo #68

Open
oleiade opened this issue Sep 30, 2022 · 2 comments
Open

Move the summary jslib in a dedicated repo #68

oleiade opened this issue Sep 30, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@oleiade
Copy link
Member

oleiade commented Sep 30, 2022

It has been decided internally to not hold any actual jslib code in the repository itself anymore. As a result, we should move the summary jslib into a dedicated repository. As a matter of fact, a repository already exists but is not used by the jslib repository.

Thus we should go through the necessary steps to include the summary jslib from its dedicated repo as follows:

  1. add a build system to the k6-jslib-summary repo able to produce build files
  2. create a build and release for its latest version
  3. include this version and its build files in the jslib repo
  4. remove the actual summary code present in the repo

🖖🏻

@na--
Copy link
Member

na-- commented Sep 30, 2022

👍 Another step here is to release another version of the summary library (v0.0.2? v0.1.0? v1.0.0 - not sure) with the slightly newer code that lives in the k6 repo: https://github.com/grafana/k6/blob/master/js/summary.js

@oleiade
Copy link
Member Author

oleiade commented Sep 30, 2022

will do 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants