Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key file names should contain stack ID and cluster #130

Open
dafydd-t opened this issue Oct 16, 2024 · 0 comments
Open

key file names should contain stack ID and cluster #130

dafydd-t opened this issue Oct 16, 2024 · 0 comments

Comments

@dafydd-t
Copy link
Contributor

PDC agent writes multiple files to the default ~/.ssh directory as part of its setup. When running multiple PDC agents to different stacks from the same machine, this can cause ssh key ovewrites unless the --ssh-key-path flag is used.

We can avoid this behaviour by default by adding the stackID and cluster value to the file names - including known hosts.

So, for stack 123 in region prod-us-east-0, instead of these:

grafana_pdc
grafana_pdc-cert.pub
grafana_pdc.pub
grafana_pdc_hash
grafana_pdc_known_hosts

We should have something like:

grafana_pdc_123_prod-us-east-0
grafana_pdc_123_prod-us-east-0-cert.pub
grafana_pdc_123_prod-us-east-0.pub
grafana_pdc_hash_123_prod-us-east-0
grafana_pdc_known_hosts_123_prod-us-east-0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant