Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality that can be used as a livenessProbe / Healthcheck #26

Open
dafydd-t opened this issue Jun 12, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@dafydd-t
Copy link
Contributor

Consider adding functionality that can be used in Kubernetes liveness probes & docker HEALTHCHECKs to determine whether the pdc-agent is running successfully.

Both of these technologies allow liveness to be determined via a command. One approach we could take is to use the existence of a file as a signal that the container is healthy. See an example in the kubernetes doc.

We should put this behind a feature flag to avoid creating unneccessary files on user systems in the case where the agent is not being run on Docker / k8s.

@dafydd-t dafydd-t added the enhancement New feature or request label Jun 12, 2023
@dafydd-t
Copy link
Contributor Author

dafydd-t commented Apr 2, 2024

I think the basic requirement here will be achieved by #41 , where we can use a 2xx response from the /metrics path as a liveness probe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant