Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for legacyMode #63

Open
dafydd-t opened this issue Feb 12, 2024 · 0 comments
Open

Remove code for legacyMode #63

dafydd-t opened this issue Feb 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dafydd-t
Copy link
Contributor

Currently the legacyMode, detected if the args contain certain openssh flags, doesn't work: The logic is never reached because since #59, we parse the flags before we check for legacyMode.

I think we should remove the code for legacyMode, as we don't need it for local dev anymore and there don't seem to be anyone using an unpinned version of the agent with legacyMode as we've not had any complaints about it breaking.

@dafydd-t dafydd-t changed the title Either support or remove code for legacyMode Remove code for legacyMode Feb 12, 2024
@dafydd-t dafydd-t added the bug Something isn't working label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant