From 1e9fda0a58e452bdb611b9a61f5617bdb7e8f60d Mon Sep 17 00:00:00 2001 From: ankur22 Date: Thu, 11 Aug 2022 16:35:03 +0100 Subject: [PATCH] Add timeout to WaitForNavigation --- tests/frame_manager_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/frame_manager_test.go b/tests/frame_manager_test.go index d260ff6dd..b2c705c23 100644 --- a/tests/frame_manager_test.go +++ b/tests/frame_manager_test.go @@ -112,9 +112,13 @@ func TestWaitForFrameNavigation(t *testing.T) { Timeout: common.DefaultTimeout, }))) + var timeout time.Duration = 5000 // interpreted as ms + var wfnPromise, cPromise *goja.Promise err := tb.await(func() error { - wfnPromise = p.WaitForNavigation(nil) + wfnPromise = p.WaitForNavigation(tb.toGojaValue(&common.FrameWaitForNavigationOptions{ + Timeout: timeout, // interpreted as ms + })) cPromise = p.Click(`a`, nil) assert.Equal(t, goja.PromiseStatePending, wfnPromise.State())