From 95ec07c16d5869ba7b736a0ef514c055d98548b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=B0nan=C3=A7=20G=C3=BCm=C3=BC=C5=9F?= Date: Wed, 17 Apr 2024 17:42:02 +0300 Subject: [PATCH] Fix Page|EHandle.Tap linter warns --- common/element_handle.go | 3 ++- common/page.go | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/common/element_handle.go b/common/element_handle.go index d8feb5601..0f0045775 100644 --- a/common/element_handle.go +++ b/common/element_handle.go @@ -1290,6 +1290,7 @@ func (h *ElementHandle) setInputFiles(apiCtx context.Context, payload []*File) e return nil } +// Tap scrolls element into view and taps in the center of the element. func (h *ElementHandle) Tap(opts goja.Value) { parsedOpts := NewElementHandleTapOptions(h.defaultTimeout()) err := parsedOpts.Parse(h.ctx, opts) @@ -1308,7 +1309,7 @@ func (h *ElementHandle) Tap(opts goja.Value) { applySlowMo(h.ctx) } -func (h *ElementHandle) tap(apiCtx context.Context, p *Position) error { +func (h *ElementHandle) tap(_ context.Context, p *Position) error { return h.frame.page.Touchscreen.tap(p.X, p.Y) } diff --git a/common/page.go b/common/page.go index 145ce326d..1c93eb17a 100644 --- a/common/page.go +++ b/common/page.go @@ -1190,6 +1190,7 @@ func (p *Page) SetViewportSize(viewportSize goja.Value) { applySlowMo(p.ctx) } +// Tap will tap the element matching the provided selector. func (p *Page) Tap(selector string, opts goja.Value) error { p.logger.Debugf("Page:SetViewportSize", "sid:%v selector:%s", p.sessionID(), selector)